[codex] Update clinical guide for Node 24#78
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
87d40b1 to
9d22f89
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
You’re right — I don’t see any currently unfixed Copilot review items in code. The remaining open threads look stale (left open after follow-up commits), including:
All of those are now addressed in the current branch state; they likely just need to be manually marked resolved in the PR UI. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 33 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
tests/ui-smoke.spec.ts:56
- The newly added
legacyDocumentsMode.isVisible().catch(() => false)guard duplicates the existingisVisibleWithoutThrowcheck and introduces an unmatched{, which will cause a syntax/typecheck failure in this test file.
tests/ui-smoke.spec.ts:73 - This
await expect(async () => { ... })block is missing its closing}).toPass(...)before the nextconst appModeMenu = ...redeclaration, which breaks the function structure and will fail TypeScript compilation. It also leaves two competing implementations of the app-mode menu flow in the same function.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Restore @supabase/supabase-js to ^2.108.2, openai to ^6.45.0, and postgres to 3.4.9. These were accidentally downgraded from the versions present in main during the Node 24/npm 11 lockfile refresh. Regenerate package-lock.json with the correct resolved versions.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 33 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
package.json:83
- This PR downgrades several direct dependencies (e.g.
@supabase/supabase-js2.108.2 -> 2.107.0 andopenai6.45.0 -> 6.42.0). Because the PR description focuses on moving runtime gates to Node 24 / npm 11 and UI polish, these version rollbacks look potentially accidental or at least need an explicit rationale (and ideally a link to the incompatibility / regression that required them). If the downgrades are intentional, please document why; otherwise revert them and regenerate the lockfile to keep the PR scoped to the runtime/doc/UI changes.
"@next/env": "16.2.9",
"@supabase/supabase-js": "^2.108.2",
"exceljs": "^4.4.0",
"jszip": "^3.10.1",
"lucide-react": "^1.21.0",
"mammoth": "^1.12.0",
"next": "16.2.9",
"openai": "^6.45.0",
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 33 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
vitest.config.mts:17
new URL("./src", import.meta.url).pathnamecan produce non-portable paths (notably on Windows, where it yields/C:/...and uses forward slashes). Since this repo already usesfileURLToPathelsewhere, prefer that here so Vitest/Vite alias resolution is cross-platform.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f2ccd5656
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ling' into copilot/simplify-operational-tooling # Conflicts: # tests/ui-smoke.spec.ts
Summary
Validation
node -v->v24.15.0npm -v->11.12.1node scripts/check-node-engine.cjspassedgit diff --cached --checkpassed before commitKnown local verification blocker
npm run verify:cheapcould not be completed locally because npm install/ci repeatedly hit Windows extraction errors and left an incomplete generatednode_modulestree. The committed source/config changes are pushed; CI should install from a clean runner using the updated Node 24 workflow.